tests: extend remap-path-prefix-std to all stdlib rlibs#156570
Open
paradoxicalguy wants to merge 1 commit into
Open
tests: extend remap-path-prefix-std to all stdlib rlibs#156570paradoxicalguy wants to merge 1 commit into
paradoxicalguy wants to merge 1 commit into
Conversation
rustbot
added
A-run-make
Urgau
reviewed
May 14, 2026
This comment has been minimized.
This comment has been minimized.
paradoxicalguy
force-pushed
the
test-extend-rmake-clean
branch
from
4c83da0 to
6a3fc8b
Compare
Member
|
@bors try jobs=dist-x86_64-linux |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 14, 2026
tests: extend remap-path-prefix-std to all stdlib rlibs try-job: dist-x86_64-linux
Contributor
Urgau
approved these changes
May 14, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 14, 2026
…lean, r=Urgau tests: extend remap-path-prefix-std to all stdlib rlibs ### problem: the current `remap-path-prefix-std` run-make test validates path remapping for `libstd.rlib`, which leaves the rest of the distributed `stdlib` artifacts unchecked. ### fix: generalizing the test to go over over all distributed `.rlib` files found in the target `sysroot libdir` instead of checking only the `libstd`. ### result: improves reproducibility coverage for distributed `stdlib` artifacts. r? @Urgau
Contributor
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#156584), which was unapproved. |
Urgau
reviewed
May 15, 2026
This comment has been minimized.
This comment has been minimized.
paradoxicalguy
force-pushed
the
test-extend-rmake-clean
branch
from
94d97b7 to
afa7f77
Compare
Member
|
Let's do a quick try run to be sure. @bors try jobs=dist-i586-gnu-i586-i686-musl |
rust-bors Bot
pushed a commit
that referenced
this pull request
May 15, 2026
tests: extend remap-path-prefix-std to all stdlib rlibs try-job: dist-i586-gnu-i586-i686-musl
This comment has been minimized.
This comment has been minimized.
Contributor
|
💔 Test for e47907c failed: CI. Failed job:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
Seems like a real error. CI is truncated, you will have to re-run the test locally to figure-out the reason for the failure. |
Contributor
Author
|
yes i'll get to it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem:
the current
remap-path-prefix-stdrun-make test validates path remapping forlibstd.rlib, which leaves the rest of the distributedstdlibartifacts unchecked.fix:
generalizing the test to go over over all distributed
.rlibfiles found in the targetsysroot libdirinstead of checking only thelibstd.result:
improves reproducibility coverage for distributed
stdlibartifacts.r? @Urgau