Skip to content

Add FileCheck for build_correct_coerce#156578

Open
eval-exec wants to merge 1 commit into
rust-lang:mainfrom
eval-exec:mir-opt-build-correct-coerce-filecheck
Open

Add FileCheck for build_correct_coerce#156578
eval-exec wants to merge 1 commit into
rust-lang:mainfrom
eval-exec:mir-opt-build-correct-coerce-filecheck

Conversation

@eval-exec
Copy link
Copy Markdown
Contributor

@eval-exec eval-exec commented May 14, 2026

part of #116971

Copilot AI review requested due to automatic review settings May 14, 2026 16:31
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 14, 2026

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds inline FileCheck assertions to the existing MIR optimization regression test for build_correct_coerce, enabling automated validation of the expected coercion target in generated MIR.

Changes:

  • Removed //@ skip-filecheck.
  • Added FileCheck expectations for main to assert the coerced function pointer type and assignment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants