Skip to content

Remove unused code in rust-analyzer#156580

Closed
mu001999 wants to merge 1 commit into
rust-lang:mainfrom
mu001999-contrib:cleanup/ra
Closed

Remove unused code in rust-analyzer#156580
mu001999 wants to merge 1 commit into
rust-lang:mainfrom
mu001999-contrib:cleanup/ra

Conversation

@mu001999
Copy link
Copy Markdown
Member

Extracted from #146440

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 14, 2026

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. labels May 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 14, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Fallback group: @Mark-Simulacrum, @jieyouxu
  • @Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu
  • Random selection from Mark-Simulacrum, jieyouxu

@lnicola
Copy link
Copy Markdown
Member

lnicola commented May 14, 2026

If it's not urgent, please file this against https://github.com/rust-lang/rust-analyzer/. It will get synced back on Monday or so.

@ChayimFriedman2
Copy link
Copy Markdown
Contributor

There definitely isn't any reason to put this in #146440 or in any PR in rust-lang/rust, this should be a PR in rust-lang/rust-analyzer.

@mu001999
Copy link
Copy Markdown
Member Author

Moved to rust-lang/rust-analyzer#22365

@mu001999 mu001999 closed this May 15, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2026
@mu001999 mu001999 deleted the cleanup/ra branch May 15, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants