Split LintExpectationIds#156596
Open
nnethercote wants to merge 5 commits into
Open
Conversation
It has a single call site.
It's always `None`.
Collaborator
|
The Clippy subtree was changed cc @rust-lang/clippy |
rustbot
added
S-waiting-on-review
| // -A,-W,-D flags, a `Symbol` for the flag itself and `LevelSpec` for which | ||
| // flag. | ||
| specs: FxIndexMap<LintId, LevelSpec>, | ||
| // -A,-W,-D flags, a `Symbol` for the flag itself and `LevelSpec` for which flag. |
Member
There was a problem hiding this comment.
Is there still a Symbol in here?
Contributor
Author
There was a problem hiding this comment.
No. LintId wraps Lint which contains a &'static str for the lint name. And the -A,-W,-D part I think is also inaccurate, it's about the lint level which could be specified on the command line but also via an attribute like #[allow(...)].
I think the comment is very out of date and it wasn't that informative anyway. The type itself is fairly straightforward and any alternative comment I could come up with was just something obvious like "a map of lints to lint levels". So I have just removed it.
`LintExpectationId` has two variants, `Unstable` and `Stable`. There are some places where both variants are possible, but there are also places where only one of `Unstable` or `Stable` is possible. This commit encodes this into the type system by introducing new types `UnstableLintExpectationId` and `StableLintExpectationId`. The variants of `LintExpectationId` now enclose these. This makes it clearer what values are possible where. Other things of note: - `LintLevelsProvider` gets an associated type and some method changes. - `LintContext` gets an associated type. - `LevelSpec` is made generic. `UnstableLevelSpec` and `StableLevelSpec` typedefs are added. - The unstable types are now guaranteed by the type system to never be stably hashed. Previously this was a runtime check.
I find these make the code harder to understand.
Describing things that took me a while to work out.
nnethercote
force-pushed
the
split-LintExpectation
branch
from
d8bcae9 to
6c9d519
Compare
GuillaumeGomez
approved these changes
May 16, 2026
Member
|
Thanks! r=me once CI pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes clearer where stable and unstable
LintExpectationIdscan occur, plus a few other small cleanups. Details in individual commits.r? @GuillaumeGomez