Rollup of 8 pull requests#156605
Closed
JonathanBrouwer wants to merge 19 commits into
Closed
Conversation
actually run the temp_dir doctest No idea why this currently doesn't get run. That said, this might fail in Miri, so we may have to wait for rust-lang/miri#5029.
…ream, r=petrochenkov Implement pinned drop sugar Implements `fn drop(&pin mut self)` as sugar for `Drop::pin_drop`. The resolver recognizes `fn drop(&pin mut self)` syntactically in trait impls and performs lookup using the effective `pin_drop` name. AST lowering independently rechecks the syntactic sugar, validates that the resolved item belongs to the actual `Drop` lang trait, and emits HIR with ident `pin_drop` for accepted sugar. Existing type checking, Drop validation, drop glue, and direct-call checks remain unchanged. Drop identity is checked during AST lowering through `tcx.lang_items().drop_trait()`, after resolver has performed the effective `pin_drop` lookup. The resolver does not need to know whether the trait is the actual `Drop` lang item, and it no longer passes marked impl item IDs to lowering. This intentionally preserves the base pinned-drop behavior where `#[pin_v2]` types must use `pin_drop`, while non-`#[pin_v2]` types may still implement `pin_drop`. r? @petrochenkov ## Related rust-lang#144537 rust-lang#130494
…BoxyUwU Make const param default test reproduce original ICE As discussed in [comment](rust-lang#156325 (comment)). ICE using old logic: [old-logic-ice.txt](https://github.com/user-attachments/files/27797628/old-logic-ice.txt) r? BoxyUwU
…utf8-pattern, r=ChrisDenton Require UTF-8 in `Utf8Pattern::StringPattern` Store `&str` instead, so the UTF-8 invariant is enforced at the API boundary. Fixes rust-lang#156491
…, r=petrochenkov delegation: emit error when self type is not specified and accessed This PR adds error reporting when we create error self type if it was not specified. In most of the tests there were other errors, so this delayed bug was not triggered, but there are cases like `reuse Default::default;` (rust-lang#156388) which does not emit other errors and those delayed bugs are triggered. Part of rust-lang#118212. Fixes rust-lang#156388. r? @petrochenkov
…=mejrs Test EII UI tests with prefer-dynamic Tracking issue: rust-lang#125418 Remove `no-prefer-dynamic` from the EII UI tests now that rust-lang#153648 fixed exporting EII declaration aliases from dylibs. Fixes rust-lang#151271. Tested with: ```sh python3 x.py test tests/ui/eii --force-rerun ```
…i-obk Use DropCtxt::new_block and new_block_with_statements systematically. Misc cleanups I found while staring at that code.
…xpansion, r=Urgau Correctly handle associated items in rustdoc macro expansion Fixes rust-lang#156075. The bug was simply that it didn't cover associated items. r? @Urgau
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 15, 2026
…uwer Rollup of 8 pull requests Successful merges: - #156493 (actually run the temp_dir doctest) - #156452 (Implement pinned drop sugar) - #156600 (Make const param default test reproduce original ICE) - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`) - #156565 (delegation: emit error when self type is not specified and accessed) - #156577 (Test EII UI tests with prefer-dynamic) - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.) - #156587 (Correctly handle associated items in rustdoc macro expansion)
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for e08cfd9 failed: CI. Failed job:
|
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #156577, which is a member of this rollup, was unapproved. |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Utf8Pattern::StringPattern#156556 (Require UTF-8 inUtf8Pattern::StringPattern)r? @ghost
Create a similar rollup