Skip to content

-Znext-solver Less normalizes-to janks#156619

Open
ShoyuVanilla wants to merge 5 commits into
rust-lang:mainfrom
ShoyuVanilla:less-normalizes-to-jank
Open

-Znext-solver Less normalizes-to janks#156619
ShoyuVanilla wants to merge 5 commits into
rust-lang:mainfrom
ShoyuVanilla:less-normalizes-to-jank

Conversation

@ShoyuVanilla
Copy link
Copy Markdown
Member

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 15, 2026

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

changes to inspect_obligations.rs

cc @lcnr

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 15, 2026
@ShoyuVanilla
Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 15, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 15, 2026
@ShoyuVanilla
Copy link
Copy Markdown
Member Author

I haven't done the nested goals' recursion depth part yet 😅 I'm gonna work on it if the overall design here pan out to be feasible

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 15, 2026

☀️ Try build successful (CI)
Build commit: d4c528b (d4c528b37c59bf04c41ddba6375584d284d1a9ba, parent: 88ba7fbe0a6eda36e0adbfd0482856f3784031b9)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (d4c528b): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.4% [0.3%, 0.8%] 7
Regressions ❌
(secondary)
22.5% [0.6%, 46.0%] 12
Improvements ✅
(primary)
-0.3% [-0.7%, -0.1%] 20
Improvements ✅
(secondary)
-0.3% [-0.6%, -0.2%] 29
All ❌✅ (primary) -0.1% [-0.7%, 0.8%] 27

Max RSS (memory usage)

Results (primary 1.5%, secondary 8.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.5% [0.9%, 2.6%] 5
Regressions ❌
(secondary)
11.4% [2.0%, 25.8%] 8
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-14.8% [-14.8%, -14.8%] 1
All ❌✅ (primary) 1.5% [0.9%, 2.6%] 5

Cycles

Results (secondary 26.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
26.9% [17.5%, 41.5%] 9
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 510.626s -> 509.733s (-0.17%)
Artifact size: 398.07 MiB -> 398.06 MiB (-0.00%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 15, 2026
@ShoyuVanilla
Copy link
Copy Markdown
Member Author

Oh, the perf regressions are insane 😅 I'll look into them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants