Skip to content

rename unexpected_try_recover function#156635

Open
bb1yd wants to merge 1 commit into
rust-lang:mainfrom
bb1yd:rename_unexpected_try_recover
Open

rename unexpected_try_recover function#156635
bb1yd wants to merge 1 commit into
rust-lang:mainfrom
bb1yd:rename_unexpected_try_recover

Conversation

@bb1yd
Copy link
Copy Markdown
Contributor

@bb1yd bb1yd commented May 16, 2026

While reading the code, the doc comment and the name of the function unexpected_try_recover confused me. The doc said it tries to recover if it is a closing delimiter but I see no recovering code and the function always return an error.

So I change the name of the function to unexpected_err and change the return value to Diag<'a>. I also update the doc comment.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 16, 2026

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 16, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 16, 2026

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, parser
  • compiler, parser expanded to 73 candidates
  • Random selection from 17 candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants