Skip to content

library: Fix std compilation for espidf target in unix::process#156638

Open
FelixLttks wants to merge 1 commit into
rust-lang:mainfrom
FelixLttks:fix-espidf-sigkill
Open

library: Fix std compilation for espidf target in unix::process#156638
FelixLttks wants to merge 1 commit into
rust-lang:mainfrom
FelixLttks:fix-espidf-sigkill

Conversation

@FelixLttks
Copy link
Copy Markdown

@FelixLttks FelixLttks commented May 16, 2026

Fixes a regression on the riscv32imac-esp-espidf target caused by commit 7bf5fe7 (linked issue #156537) . The unix_kill_process_group feature attempts to use libc::SIGKILL, which is not supported on the espidf target.

Discussed in esp-idf-sys issue: esp-rs/esp-idf-sys#419

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 16, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 16, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants