Rollup of 9 pull requests#156663
Closed
JonathanBrouwer wants to merge 25 commits into
Closed
Conversation
…r` is found This commit adds a diagnostic suggestion to help users who forget to call `.collect()` when they have an iterator and the function or variable expects a `String`. The logic checks if the expected type is `std::string::String` and if the found type implements the `Iterator` trait, if so the compiler provides a suggestion to add `.collect()` Includes also a UI test to verify if the suggestion appears correctly
Co-authored-by: Qai Juang <qaijuang@gmail.com>
This works, but I couldn't find any test cases for it.
…, r=estebank Add interior-mutability suggestion to `static_mut_refs` Closes rust-lang#151131 r? @estebank I've skipped to expand catching below code as a mutable _reference_ shouldn't be involved (maybe a new lint would be needed?): ```rs static mut COUNTER: u64 = 0; fn main() { unsafe { COUNTER = 1 }; } ```
…ing, r=estebank compiler: suggest `.collect()` when `String` is expected and `Iterator` is found This commit adds a diagnostic suggestion to help users who forget to call `.collect()` when they have an iterator and the function or variable expects a `String`. The logic checks if the expected type is `std::string::String` and if the found type implements the `Iterator` trait, if so the compiler provides a suggestion to add `.collect()` Includes also a UI test to verify if the suggestion appears correctly
suggest hex escapes for C-style escapes Fixes rust-lang#148884.
…=mejrs Test EII UI tests with prefer-dynamic Tracking issue: rust-lang#125418 Remove `no-prefer-dynamic` from the EII UI tests now that rust-lang#153648 fixed exporting EII declaration aliases from dylibs. Fixes rust-lang#151271. Tested with: ```sh python3 x.py test tests/ui/eii --force-rerun ```
…1999 Avoid rustfix suggestions for macro-expanded unused imports Avoid emitting rustfix suggestions for unused imports when the removal span is not directly editable. Closes rust-lang#147855
…uillaumeGomez rustdoc: add test case for `-Drustdoc::` and `--cap-lints` This works, but I couldn't find any test cases for it.
…est, r=mu001999 Add regression test for issue rust-lang#41261 Adds a regression test for rust-lang#41261.
…r, r=JohnTitor rename unexpected_try_recover function While reading the code, the doc comment and the name of the function `unexpected_try_recover` confused me. The doc said it tries to recover if it is a closing delimiter but I see no recovering code and the function always return an error. So I change the name of the function to `unexpected_err` and change the return value to `Diag<'a>`. I also update the doc comment.
…=Kivooeo minor `rustc_mir_transform` cleanup Some minor things I noticed here and there while reading though code
rustbot
added
S-waiting-on-review
Contributor
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Trying commit fa73156 with merge f87296a… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/25989451829 |
rust-bors Bot
pushed a commit
that referenced
this pull request
May 17, 2026
Rollup of 9 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
Contributor
Author
|
@bors try cancel |
Contributor
|
Try build cancelled. Cancelled workflows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
static_mut_refs#151362 (Add interior-mutability suggestion tostatic_mut_refs).collect()whenStringis expected andIteratoris found #156121 (compiler: suggest.collect()whenStringis expected andIteratoris found)-Drustdoc::and--cap-lints#156616 (rustdoc: add test case for-Drustdoc::and--cap-lints)rustc_mir_transformcleanup #156636 (minorrustc_mir_transformcleanup)r? @ghost
Create a similar rollup