Rollup of 12 pull requests#157149
Merged
Merged
Conversation
And reduce visibility of functions only used within the crate.
cg_clif needs this as it passes inline assembly to an external assembler, producing a separate object file. Currently it emits multiple CompiledModules, but this is not compatible with using the codegen coordinator of cg_ssa.
…and move its `Diagnostic` impl
…guous_assoc_item`
Moreover, in `probe_single_bound_for_assoc_item` unconditionally return
an `Err(_)` if there's more than a single bound (aka ambiguity) instead
of returning the first bound in some cases. This avoids triggering a
debug assertion later on ("not enough bound vars"). See the added test
for details.
The type's been stable for over 6 weeks now, so let's use it! It's better for cases like this one where it's stored in a data structure. Probably won't be materially faster, but does make the variant slightly smaller and lets some more things be `Copy`.
…n()` syntax registrations of it, they are never used
…_traits, r=cjgillot Remove `will_cache_on_disk_for_key_fn` Refactors `QueryVtables` and removes `will_cache_on_disk_for_key_fn` as unnecessary indirection. Based and blocked on rust-lang#154576. Expecting perf improvements.
Misc improvements to coroutine transform code Several quality-of-life improvements: A dedicated mir-opt directory for coroutines, there are very few tests right now, but more should come. A dedicated pretty-printer for coroutine layout. In particular, it does not rely on `Ty as Debug` which has unstable output. This is important for async fns which capture opaque types, in particular other async fns. A drive-by simplification. Last, I change how the coroutine entry block is inserted. The current implementation shifts everything by 1. I prefer swapping with the current entry, which makes debugging and MIR diffing much easier.
Contributor
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 30, 2026
Rollup of 12 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2
Contributor
Author
|
@bors treeopen |
Contributor
|
Tree is now open for merging. |
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 6eda741 (parent) -> a857d06 (this PR) Test differencesShow 98 test diffsStage 1
Stage 2
Additionally, 46 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a857d063c754e3b09a74baf67d319cea3c0e0264 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 6eda7419e7 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced May 30, 2026
Collaborator
|
Finished benchmarking commit (a857d06): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.1%, secondary 2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 4.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 518.609s -> 523.807s (1.00%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
will_cache_on_disk_for_key_fn#154591 (Removewill_cache_on_disk_for_key_fn)trait_object_dummy_selfmore & heavily fix+update related docs #153497 (Usetrait_object_dummy_selfmore & heavily fix+update related docs)AsyncFnarg mismatch diagnostic #155638 (Fix tupled closure signature inAsyncFnarg mismatch diagnostic)()no-break rule applies past max width #156826 (style: Clarify nullary call and()no-break rule applies past max width)value_analysis.rs#157004 (Remove unused functions invalue_analysis.rs)ops::RangeInclusive→range::RangeInclusive#157139 (compiler:ops::RangeInclusive→range::RangeInclusive)Failed merges:
yieldterminator #156875 (Correct and document semantics ofyieldterminator)r? @ghost
Create a similar rollup