Change type of async context parameter after state transform.#157166
Open
cjgillot wants to merge 2 commits into
Open
Change type of async context parameter after state transform.#157166cjgillot wants to merge 2 commits into
cjgillot wants to merge 2 commits into
Conversation
Collaborator
|
This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @vakaras Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Collaborator
|
r? @tiif rustbot has assigned @tiif. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
8447533 to
8c16d8a
Compare
This comment has been minimized.
This comment has been minimized.
8c16d8a to
ab5076b
Compare
This comment has been minimized.
This comment has been minimized.
ab5076b to
769048f
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
769048f to
89aaf42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Future::pollexpects a&mut std::task::Context<'_>. Meanwhile, async coroutines usestd::future::ResumeTyas resume parameter. This is meant to workaround the limitations of borrowck, which cannot prove that coroutines implementfor<'a, 'b> CoroutineTrait<&'a mut Context<'b>>.In the coroutine state transform, we need to change the signature from
ResumeTyto the proper&mut Context<'_>. The current code attempts to find locals that have typeResumeTyto change their type. This is needlessly complex and relies on undocumented behaviour of the MIR builder.Instead, this PR proposes to replace the
ResumeTyargument with a new local, with valueResumeTy(transmute(context)).Based on #156875.