-
Notifications
You must be signed in to change notification settings - Fork 325
Add _mm_clflushopt intrinsic
#2141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jlpetz
wants to merge
5
commits into
rust-lang:main
Choose a base branch
from
jlpetz:clflushopt-intrinsic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
48f6b2f
Add `_mm_clflushopt` intrinsic
jlpetz 6f9fbf1
Address review feedback: Safety docs added, extern signature to *cons…
jlpetz dc60b5f
Enable clflushopt_target_feature gate in core_arch crate attributes
jlpetz 64df571
Remove redundant intra-doc link definitions in _mm_clflushopt
jlpetz 206b5a4
Use unadjusted ABI and restore intra-doc links with crate::arch::x86
jlpetz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| //! `CLFLUSHOPT` cache-line flush. | ||
|
|
||
| #[cfg(test)] | ||
| use stdarch_test::assert_instr; | ||
|
|
||
| #[allow(improper_ctypes)] | ||
| unsafe extern "unadjusted" { | ||
| #[link_name = "llvm.x86.clflushopt"] | ||
| fn clflushopt(p: *const u8); | ||
| } | ||
|
|
||
| /// Invalidates from every level of the cache hierarchy the cache line that | ||
| /// contains `p`. | ||
| /// | ||
| /// Unlike [`_mm_clflush`], `CLFLUSHOPT` is only ordered with respect to older | ||
| /// writes to the flushed cache line and with respect to fence/locked | ||
| /// operations; it is *not* serialized against other `CLFLUSHOPT`/`CLFLUSH` | ||
| /// instructions or unrelated stores. This makes flushing a range of lines | ||
| /// substantially faster, but a fence (e.g. [`_mm_sfence`] or [`_mm_mfence`]) is | ||
| /// required afterward to order the flushes against subsequent operations. | ||
| /// | ||
| /// [Intel's documentation](https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_mm_clflushopt) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For consistency you can add the same section to the |
||
| /// | ||
| /// # Safety | ||
| /// | ||
| /// Unlike the prefetch intrinsics, `CLFLUSHOPT` is subject to all the | ||
| /// permission checking and faults associated with a byte load, so `p` must | ||
| /// point to a byte that is valid for reads. | ||
| /// | ||
| /// [`_mm_clflush`]: crate::arch::x86::_mm_clflush | ||
| /// [`_mm_sfence`]: crate::arch::x86::_mm_sfence | ||
| /// [`_mm_mfence`]: crate::arch::x86::_mm_mfence | ||
| #[inline] | ||
| #[target_feature(enable = "clflushopt")] | ||
| #[cfg_attr(test, assert_instr(clflushopt))] | ||
| #[unstable(feature = "simd_x86_clflushopt", issue = "157096")] | ||
| pub unsafe fn _mm_clflushopt(p: *const u8) { | ||
| clflushopt(p); | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use crate::core_arch::x86::*; | ||
| use stdarch_test::simd_test; | ||
|
|
||
| #[simd_test(enable = "clflushopt")] | ||
| unsafe fn test_mm_clflushopt() { | ||
| let x = 0_u8; | ||
| _mm_clflushopt(core::ptr::addr_of!(x)); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.