Merged
Conversation
Member
Author
|
Double checking running an updated version of edit. err.., well that would make sense at the very least because I have so far only updated the game-activity backend ... |
The `ALooper_pollAll` API is deprecated and considering that `poll_events` never promised the behaviour of `pollAll` we simply change the implementation to use `ALoooper_pollOnce` and assume the caller is going to anyway be calling `poll_events` within its own loop. Note: `pollOnce` can still deliver multiple callback events, and the "once" effectively just refers to only calling `epoll_wait` at most once. Considering winit for example, this should have no effect since winit will be calling `poll_events` in a loop with no assumption about how concurrent events could potentially be batched. Fixes: #170
rib
force-pushed
the
rib/pr/avoid-deprecated-poll-all
branch
from
83124dd to
f08d7b3
Compare
Member
Author
|
Ok, I've now tested with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ALooper_pollAllAPI is deprecated and considering thatpoll_eventsnever promised the behaviour ofpollAllwe simply change the implementation to useALoooper_pollOnceand assume the caller is going to anyway be callingpoll_eventswithin its own loop.Note:
pollOncecan still deliver multiple callback events, and the "once" effectively just refers to only callingepoll_waitat most once.Considering winit for example, this should have no effect since winit will be calling
poll_eventsin a loop with no assumption about how concurrent events could potentially be batched.Fixes: #170