Skip to content

Conversation

@dhardy
Copy link
Member

@dhardy dhardy commented Dec 6, 2025

Corresponds to rust-random/rand_core#34

Needs to be merged with #80 derivative.

@dhardy
Copy link
Member Author

dhardy commented Dec 6, 2025

Test failures concern serde (needs further rand_core changes to fix).

@dhardy dhardy marked this pull request as ready for review December 22, 2025 14:20
@dhardy
Copy link
Member Author

dhardy commented Dec 22, 2025

Self-review notes:

Isaac*Rng serde code is inelegant and contains a "TODO" comment, but tests pass and I don't really care about rand_isaac (I'm not sure if anyone does; the main reason I bothered to write this code at all is as a serde test case for a block RNG).

Isaac64Rng has value-breaking changes when invoking next_u32() twice in a row. This is noted in the CHANGELOG and deemed of low importance due to low usage of rand_isaac.

rand_isaac now requires serde_arrays for serde support. This is a small crate depending only on serde.

IsaacArray (internal type) is no longer required.

All other changes are reassuringly boring and minimal with no test changes required.

@dhardy dhardy merged commit a514fea into master Dec 22, 2025
11 checks passed
@dhardy dhardy mentioned this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants