Skip to content

winit-x11: replace XQueryKeymap with equivalent x11rb call#4497

Open
jgcodes2020 wants to merge 3 commits intorust-windowing:masterfrom
jgcodes2020:x11rb-keymap
Open

winit-x11: replace XQueryKeymap with equivalent x11rb call#4497
jgcodes2020 wants to merge 3 commits intorust-windowing:masterfrom
jgcodes2020:x11rb-keymap

Conversation

@jgcodes2020
Copy link

@jgcodes2020 jgcodes2020 commented Feb 27, 2026

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

Don't believe this really needs any documentation changes as it's really just an implementation thing. This PR does two things:

  • replaces XQueryKeymap with XCBConnection::query_keymap
  • slightly optimizes the first_bit helper function in that same file

@madsmtm madsmtm added the DS - x11 Affects the X11 backend, or generally free Unix platforms label Feb 28, 2026
@jgcodes2020 jgcodes2020 marked this pull request as ready for review February 28, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DS - x11 Affects the X11 backend, or generally free Unix platforms

Development

Successfully merging this pull request may close these issues.

2 participants