Conversation
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the topbar inventory icon by replacing image-based rendering with a font-based icon from the BuilderIcons library. The change improves consistency and maintainability by leveraging vector icons instead of static images.
Changes:
- Replaced image-based icon (ICON_SELECTED_IMAGE and ICON_DESELECTED_IMAGE) with font-based "backpack" label using BuilderIcons
- Configured separate font weights (Bold for selected, Regular for deselected) for visual state differentiation
- Added minimum width constraint to ensure consistent icon layout
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the backpack vector icon from the builder icons font for the icon.
This pull request updates the appearance and configuration of the topbar inventory icon in
src/TopbarIcon.client.luau. The main focus is on improving the icon's label, font, and layout for better clarity and consistency.UI and Label Improvements:
Configuration Adjustments: