Skip to content

Add parent reference to embedded containers #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rytilahti merged 1 commit into from
Feb 3, 2023
Merged

Add parent reference to embedded containers #1711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions miio/devicestatus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ def __new__(metacls, name, bases, namespace, **kwargs):
cls._sensors: Dict[str, SensorDescriptor] = {}
cls._settings: Dict[str, SettingDescriptor] = {}

cls._parent: Optional["DeviceStatus"] = None
cls._embedded: Dict[str, "DeviceStatus"] = {}

descriptor_map = {
Expand Down Expand Up @@ -117,6 +118,7 @@ def embed(self, other: "DeviceStatus"):
other_name = str(other.__class__.__name__)

self._embedded[other_name] = other
other._parent = self # type: ignore[attr-defined]

for name, sensor in other.sensors().items():
final_name = f"{other_name}__{name}"
Expand Down
1 change: 1 addition & 0 deletions miio/tests/test_devicestatus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@ def sub_sensor(self):
main.embed(sub)
sensors = main.sensors()
assert len(sensors) == 2
assert sub._parent == main

assert getattr(main, sensors["main_sensor"].property) == "main"
assert getattr(main, sensors["SubStatus__sub_sensor"].property) == "sub"
Expand Down