Fix type warnings #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript in management app was throwing: Property 'getData' does not exist on type 'DirectoryEntry'. the way types were setup in zip.js, the entry is a union type and only typed as a DirectoryEntry if it had a .directory property, and as FileEntry when .file was present. Checking the properties allows typescript to infer types as it should
nathanstitt
force-pushed
the
narrow-types
branch
from
285a462 to
0dc20c2
Compare
rnathuji
approved these changes
Dec 4, 2025
chrisbendel
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typescript in management app was throwing:
Property 'getData' does not exist on type 'DirectoryEntry'.
the way types were setup in zip.js, the entry is a union type and only typed as a DirectoryEntry if it had a .directory property, and as FileEntry when .file was present. Checking the properties allows typescript to infer types as it should