-
Notifications
You must be signed in to change notification settings - Fork 9
feat: move existing templates-W-21163895 #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
94c4dd1
119aca5
4fafef9
f4fb97d
e5f00f3
cdd3554
14c2b66
d91699e
e7425cc
4b65680
a706dbc
a43b7a3
1c6cc56
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -8,16 +8,16 @@ | |||||
| import { Flags, loglevel, orgApiVersionFlagWithDeprecations, SfCommand, Ux } from '@salesforce/sf-plugins-core'; | ||||||
| import { Messages } from '@salesforce/core'; | ||||||
| import { AnalyticsTemplateOptions, CreateOutput, TemplateType } from '@salesforce/templates'; | ||||||
| import { getCustomTemplates, runGenerator } from '../../../utils/templateCommand.js'; | ||||||
| import { outputDirFlag } from '../../../utils/flags.js'; | ||||||
| import { getCustomTemplates, runGenerator } from '../../../../utils/templateCommand.js'; | ||||||
| import { outputDirFlag } from '../../../../utils/flags.js'; | ||||||
|
|
||||||
| Messages.importMessagesDirectoryFromMetaUrl(import.meta.url); | ||||||
| const messages = Messages.loadMessages('@salesforce/plugin-templates', 'analyticsTemplate'); | ||||||
| export default class AnalyticsTemplate extends SfCommand<CreateOutput> { | ||||||
| public static readonly examples = messages.getMessages('examples'); | ||||||
| public static readonly summary = messages.getMessage('summary'); | ||||||
| public static readonly description = messages.getMessage('description'); | ||||||
| public static readonly aliases = ['force:analytics:template:create']; | ||||||
| public static readonly aliases = ['force:analytics:template:create', 'analytics generate template']; | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For consistency, lets use
Suggested change
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Check the other aliases that were added
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it throw an error:
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh funny. I think you just found an far edge case. Here is the linting rule: https://github.com/salesforcecli/eslint-plugin-sf-plugin/blob/19bb3dcbeab9d0427a64030e3fae4cc135810d96/src/rules/no-unnecessary-aliases.ts#L43-L44 I think this is complaining because of the I confirmed that the alias does work locally so it's not an issue 🤷 |
||||||
| public static readonly deprecateAliases = true; | ||||||
| public static readonly flags = { | ||||||
| 'output-dir': outputDirFlag, | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.