[wip] salt-call and salt-pip honor configured user#68685
Open
dwoz wants to merge 11 commits intosaltstack:3006.xfrom
Open
[wip] salt-call and salt-pip honor configured user#68685dwoz wants to merge 11 commits intosaltstack:3006.xfrom
dwoz wants to merge 11 commits intosaltstack:3006.xfrom
Conversation
dwoz
changed the title
twangboy
previously approved these changes
Feb 10, 2026
twangboy
previously approved these changes
Feb 25, 2026
twangboy
previously approved these changes
Feb 27, 2026
bdrx312
reviewed
Mar 2, 2026
| if [ -f "/etc/salt/minion" ] || [ -d "/etc/salt/minion.d" ]; then | ||
| # Try to get user from main config | ||
| if [ -f "/etc/salt/minion" ]; then | ||
| MINION_USER=$(grep -E "^user:" /etc/salt/minion | cut -d ':' -f 2 | tr -d ' ') |
Contributor
There was a problem hiding this comment.
From https://docs.saltproject.io/en/latest/ref/configuration/minion.html:
The Salt Minion configuration is very simple. Typically, the only value that needs to be set is the master value so the minion knows where to locate its master.
By default, the salt-minion configuration will be in /etc/salt/minion. A notable exception is FreeBSD, where the configuration will be in /usr/local/etc/salt/minion.
- Improve default CWD fallback in cmd.run to handle non-directory home dirs (e.g. /dev/null) - Ensure /opt/saltstack/salt is chowned on fresh RPM installs - Make test_pkg_paths more robust by checking actual configured minion user - Restore missing minion user setup in test_permissions.py
Allow root, salt or configured minion user to own paths under onedir. This handles mixed ownership cases during downgrade/upgrade cycles while maintaining strict checks for other system paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68684, #68777