feat: add KVDataMemory for periodic memory usage monitoring#35
Open
feat: add KVDataMemory for periodic memory usage monitoring#35
Conversation
Contributor
|
Не нужно ли сюда инициализацию метрики добавить? |
pamellix
requested changes
Feb 16, 2026
| this.scheduleNext(); | ||
| } | ||
|
|
||
| public stopMonitoring(): void { |
Contributor
There was a problem hiding this comment.
Давай придерживаться устоявшегося нейминга, давай напишем endMonitoring -
web-telemetry/src/extra/KVDataFrameTime.ts
Line 108 in 67c0e30
| } | ||
|
|
||
| private scheduleNext(): void { | ||
| this.timerId = setTimeout(async () => { |
Contributor
There was a problem hiding this comment.
Думаю лучше тут использовать setInterval, так как мы отправляем метрики с периодичностью, а не один раз - https://developer.mozilla.org/ru/docs/Web/API/Window/setInterval
Contributor
|
И прогони приттиер - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.