Skip to content

fix: guard WebSocketClientProtocol import behind TYPE_CHECKING (fixes #1666) #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mac-agent wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

fix: guard WebSocketClientProtocol import behind TYPE_CHECKING (fixes #1666) #1687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions binance/ws/websocket_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
from typing import Dict, Optional
from typing import TYPE_CHECKING, Dict, Optional
import asyncio

from websockets import WebSocketClientProtocol # type: ignore
if TYPE_CHECKING:
from websockets import WebSocketClientProtocol # type: ignore # noqa: F401

from .constants import WSListenerState
from .reconnecting_websocket import ReconnectingWebsocket
Expand Down Expand Up @@ -117,7 +118,7 @@ async def _ensure_ws_connection(self) -> None:
try:
if (
self.ws is None
or (isinstance(self.ws, WebSocketClientProtocol) and self.ws.closed)
or (hasattr(self.ws, "closed") and self.ws.closed)
or self.ws_state != WSListenerState.STREAMING
):
await self.connect()
Expand Down