This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Open
Conversation
cbenz
reviewed
Jan 23, 2020
cbenz
reviewed
Jan 23, 2020
added 2 commits
January 23, 2020 23:12
Owner
|
Thanks a lot for the PR! I'll have to set up Wikibase and get the tests to work on my machine again, so it might take me a while to review this :) |
Owner
|
Alright, I've set up the testing environment again. Your code unfortunately isn't working yet. I've now simplified the local setup guide a lot, this should get it to work on your device, too: https://wikibase-api.readthedocs.io/en/latest/development/development.html. Please let me know if I can provide more details :) In case you get errors about duplicate items when running the tests, this might be because of a previously failed test run which didn't clean up its data properly. Creating a new Docker volume should do the trick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, we begin a project involving use of wikibase and found your module very useful.
We need to deal with data value of type "time", so here is a proposition to implement it.
It seems to work for my needs but I was not able to run the tests. I do not understand what could be the content of config-tests.xml
Could you help me?