Skip to content

Y26-005 - LCM Triomics - assign Project / Cost Code to automated submissions#2732

Merged
wendyyang merged 25 commits intoTriomic_Epicfrom
Y26-005-LCM-Triomics-assign-Project-Cost-Code
Apr 10, 2026
Merged

Y26-005 - LCM Triomics - assign Project / Cost Code to automated submissions#2732
wendyyang merged 25 commits intoTriomic_Epicfrom
Y26-005-LCM-Triomics-assign-Project-Cost-Code

Conversation

@KatyTaylor
Copy link
Copy Markdown
Collaborator

@KatyTaylor KatyTaylor commented Mar 5, 2026

Closes #

Changes proposed in this pull request

  • Quite functional code made by Github Copilot. Adds a field to the choose workflow component, which allows you to search by project id. Adds project uuid to the payload sent to Sequencescape to create the submission - this part doesn't work yet. To add - only display this field when configured to do so. Take hardcoded project out of submission template. Improve styling / UX.
  • (Update: works now)

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

…ose workflow component, which allows you to search by project id. Adds project uuid to the payload sent to Sequencescape to create the submission - this part doesn't work yet. To add - only display this field when configured to do so. Take hardcoded project out of submission template. Improve styling / UX.
@KatyTaylor KatyTaylor linked an issue Mar 5, 2026 that may be closed by this pull request
3 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 90.56604% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.06%. Comparing base (211eda5) to head (20c18aa).
⚠️ Report is 26 commits behind head on Triomic_Epic.

Files with missing lines Patch % Lines
app/frontend/entrypoints/pages/choose_workflow.js 91.11% 8 Missing ⚠️
...s/concerns/presenters/collect_project_behaviour.rb 50.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           Triomic_Epic    #2732      +/-   ##
================================================
+ Coverage         85.02%   85.06%   +0.03%     
================================================
  Files               506      504       -2     
  Lines             20733    20737       +4     
  Branches            377      377              
================================================
+ Hits              17628    17639      +11     
+ Misses             3102     3095       -7     
  Partials              3        3              
Flag Coverage Δ
javascript 80.46% <91.11%> (+0.20%) ⬆️
pull_request 85.06% <90.56%> (+0.06%) ⬆️
push 85.06% <90.56%> (+0.10%) ⬆️
ruby 92.53% <87.50%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wendyyang wendyyang marked this pull request as ready for review March 31, 2026 14:20
@KatyTudor
Copy link
Copy Markdown

Someone requested me to review something on here but think it should be @KatyTaylor

@StephenHulme
Copy link
Copy Markdown
Contributor

Can you please include screenshots of the styling changes? And expand on what has changed with the UX if there are any behavioural changes?

Comment thread app/controllers/plates_controller.rb
@StephenHulme
Copy link
Copy Markdown
Contributor

There are a couple strange this about this PR... a Javascript test written as a Ruby spec is also strange... Can you comment on what has been created by co-pilot and what hasn't?

@KatyTaylor KatyTaylor removed the request for review from KatyTudor April 1, 2026 09:03
@wendyyang
Copy link
Copy Markdown
Contributor

project/cost code input field:
Screenshot 2026-04-01 at 14 40 10

@wendyyang
Copy link
Copy Markdown
Contributor

There are a couple strange this about this PR... a Javascript test written as a Ruby spec is also strange... Can you comment on what has been created by co-pilot and what hasn't?

Which Javascript test written as a Ruby spec? app/frontend/entrypoints/pages/choose_workflow.spec.js is created by co-pilot.

@wendyyang wendyyang requested a review from StephenHulme April 1, 2026 15:24
@wendyyang
Copy link
Copy Markdown
Contributor

wendyyang commented Apr 9, 2026

Enclose a few screenshots:

when enter a valid project code and click enter:
Screenshot 2026-04-08 at 22 24 49

when enter non-existing project code and click enter:
Screenshot 2026-04-08 at 22 25 03

when leave the field empty and click submission button:
Screenshot 2026-04-08 at 22 25 18

when the project code is valid and click the submission button:
Screenshot 2026-04-08 at 22 26 42

Comment thread app/frontend/entrypoints/pages/choose_workflow.js
Copy link
Copy Markdown
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but I think it's almost there 🙂

@wendyyang wendyyang requested a review from StephenHulme April 9, 2026 17:00
Copy link
Copy Markdown
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, looks good 👍

@wendyyang wendyyang merged commit fd4a931 into Triomic_Epic Apr 10, 2026
16 checks passed
@wendyyang wendyyang deleted the Y26-005-LCM-Triomics-assign-Project-Cost-Code branch April 10, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y26-005 - LCM Triomics - assign Project / Cost Code to automated submissions

4 participants