Skip to content

Y26-061 Bioscan - submission button not showing#2747

Merged
andrewsparkes merged 10 commits intodevelopfrom
y26-061-bioscan-submission-button-not-showing
Mar 30, 2026
Merged

Y26-061 Bioscan - submission button not showing#2747
andrewsparkes merged 10 commits intodevelopfrom
y26-061-bioscan-submission-button-not-showing

Conversation

@andrewsparkes
Copy link
Copy Markdown
Member

@andrewsparkes andrewsparkes commented Mar 17, 2026

Closes #2726

Changes proposed in this pull request

Includes the Y26-062 branch that includes checks to display PCR 1 child creation button.

Instructions for Reviewers

See associated integration suite PR here

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 98.57143% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.98%. Comparing base (7eb0768) to head (47b37bb).
⚠️ Report is 39 commits behind head on develop.

Files with missing lines Patch % Lines
...models/concerns/presenters/submission_behaviour.rb 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2747      +/-   ##
===========================================
+ Coverage    84.93%   84.98%   +0.04%     
===========================================
  Files          501      504       +3     
  Lines        20600    20667      +67     
  Branches       377      377              
===========================================
+ Hits         17497    17564      +67     
  Misses        3100     3100              
  Partials         3        3              
Flag Coverage Δ
javascript 80.25% <ø> (ø)
pull_request 84.98% <98.57%> (+0.04%) ⬆️
push 84.98% <98.57%> (+0.04%) ⬆️
ruby 92.60% <98.57%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrewsparkes
Copy link
Copy Markdown
Member Author

Have tested the following pipelines that are using SubmissionBehaviour module by running their integration suite tests:

Plates:
Bioscan - Tested OK
BGE - Tested Ok
RVI Deep Well Stamping - Tested Ok
LCM Triomics - Tested Ok
scRNA core cDNA prep - Tested Ok

Tubes:
Ultima PCR Free - Tested Ok

Copy link
Copy Markdown
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well designed, documented, and tested.

Comment thread app/models/presenters/bioscan_submission_when_passed_plate_presenter.rb Outdated
Comment thread spec/models/concerns/presenters/submission_behaviour_spec.rb Outdated
@andrewsparkes andrewsparkes merged commit e00ff45 into develop Mar 30, 2026
24 checks passed
@andrewsparkes andrewsparkes deleted the y26-061-bioscan-submission-button-not-showing branch March 30, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y26-061 - [BUG] Bioscan - Library Prep Submission button does not show for repeat runs

2 participants