Suppress ldappool INVALID_CREDENTIALS tracebacks#49
Open
bbobrov wants to merge 1 commit intostable/2025.1-m3from
Open
Suppress ldappool INVALID_CREDENTIALS tracebacks#49bbobrov wants to merge 1 commit intostable/2025.1-m3from
bbobrov wants to merge 1 commit intostable/2025.1-m3from
Conversation
The ldappool library logs ldap.INVALID_CREDENTIALS at ERROR level with a full traceback in _create_connector() every time a user provides wrong credentials. This is not a server error but a normal operational event. The ERROR tracebacks create log noise and make it harder to spot real problems. Install a logging.Filter on the 'ldappool' logger that drops ERROR records containing 'Invalid credentials'. Keystone already logs failed authentication at WARNING level in _handle_keystone_exception(), so no information is lost. Generated-By: claude-opus-4-6 (OpenCode) Signed-off-by: Boris Bobrov <b.bobrov@sap.com> Change-Id: I943c0f3b4f50e64fab1da85367b25a00b3e9b1bd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ldappool library logs ldap.INVALID_CREDENTIALS at ERROR level with a full traceback in _create_connector() every time a user provides wrong credentials. This is not a server error but a normal operational event. The ERROR tracebacks create log noise and make it harder to spot real problems.
Install a logging.Filter on the 'ldappool' logger that drops ERROR records containing 'Invalid credentials'. Keystone already logs failed authentication at WARNING level in _handle_keystone_exception(), so no information is lost.
Generated-By: claude-opus-4-6 (OpenCode)
Change-Id: I943c0f3b4f50e64fab1da85367b25a00b3e9b1bd