scheduler: Log only for vmware hosts without aggregate in ShardFilter#616
Open
joker-at-work wants to merge 1 commit intostable/2023.2-m3from
Open
scheduler: Log only for vmware hosts without aggregate in ShardFilter#616joker-at-work wants to merge 1 commit intostable/2023.2-m3from
joker-at-work wants to merge 1 commit intostable/2023.2-m3from
Conversation
grandchild
previously approved these changes
Apr 1, 2026
seb-kro
reviewed
Apr 1, 2026
joker-at-work
force-pushed
the
scheduler-shard-filter-no-log-aggregate-non-vmware
branch
from
c3ff7bb to
113e78d
Compare
The ShardFilter is not relevant for hosts that are not vmware-related, which is clear after the first check it does: checking if the request is for a vmware spec. Since with KVM we can have a lot of hosts coming in which can create a lot of logs, disable logging for non-vmware hosts entirely. We previously already reduced the log-level for ironic nodes, because of non-relevance, but since we like to run with debug-level in prod, too, not logging anything is preferred to that. Change-Id: I36b71949179c126762c9f8003e95ea0cf90ececb
grandchild
approved these changes
Apr 1, 2026
fwiesel
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ShardFilter is not relevant for hosts that are not vmware-related, which is clear after the first check it does: checking if the request is for a vmware spec.
Since with KVM we can have a lot of hosts coming in which can create a lot of logs, disable logging for non-vmware hosts entirely. We previously already reduced the log-level for ironic nodes, because of non-relevance, but since we like to run with debug-level in prod, too, not logging anything is preferred to that.
Change-Id: I36b71949179c126762c9f8003e95ea0cf90ececb