test(amqp091): fix race in Publish_ContextCancellation_ExitsPromptly#78
Open
miotte wants to merge 2 commits into
Open
test(amqp091): fix race in Publish_ContextCancellation_ExitsPromptly#78miotte wants to merge 2 commits into
miotte wants to merge 2 commits into
Conversation
Use two distinct buffered channels for the connection's two NotifyClose mock calls instead of aliasing both onto a single channel. Sharing one channel made Publish's deferred "Publish done" send wake the connectionWatcher goroutine, which then raced with the test's deferred NewAmqpConn091 restore as it called bd.connect() again. In production these are independent channels too. Signed-off-by: Michael Otteni <MichaelGOtteni@gmail.com>
Add Test_QueueSubscribe_NotifyCloseChannelsAreBuffered, mirroring the existing Publish-path test, so a future regression that re-introduces unbuffered NotifyClose channels in queueSubscribe is caught immediately. Also clarifies the comment on the Publish-path buffered-channel assertion to call out that capacity is only verified on the Publish-created channel (the last capture). Signed-off-by: Michael Otteni <MichaelGOtteni@gmail.com>
bithckr
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.