Conversation
dennybiasiolli
requested changes
Sep 16, 2017
Collaborator
dennybiasiolli
left a comment
dennybiasiolli
left a comment
There was a problem hiding this comment.
PR looks good to me, if we fix tests we can proceed and merge ;)
| $scope.pdfConfig = new NgPdfFactory('pdf/relativity.pdf', { fitToPage: true }); | ||
| $scope.protectedPdfConfig = new NgPdfFactory('pdf/relativity.protected.pdf', { fitToPage: true, useCredentials: true, password: 'test' }); | ||
|
|
||
| $scope.$watch('pdfUrl', (newVal, oldVal) => { |
Collaborator
There was a problem hiding this comment.
Tests are broken on PhantomJS with ES6 sintax, maybe we can try to update PhantomJS or use old ES5 sintax?
Contributor
Author
|
@*dennybiasiolli *as this is a complete new version, may I propose to
remove phantomjs and instead use the new chrome headless?
|
Collaborator
|
@endorama yes, it's a good idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @dennybiasiolli @NicoBurno, sorry for the long delay!
As I've seen no progression on this ( no pun intended! ), and I had a Torino OpenSource Saturday to spend on this, here is my implementation for the isolated scope.
This is a full refactor of the previous implementation :) All features are preserved ( apart custom http headers ).
The refactor is based on a factory object, which creates an object that can be used to manipulate the viewer status.
Please have a look and ask questions!
The
NgPdfFactoryshould be more appropriately namedNgPdfViewer.Thanks!