Use tiled matrix transposition#912
Merged
Merged
Conversation
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v22.1.6
Click here for the full clang-format patch
diff --git a/Sources/CSFBAudioEngine/Decoders/SFBDSFDecoder.m b/Sources/CSFBAudioEngine/Decoders/SFBDSFDecoder.m
index 409faae..dd8320e 100644
--- a/Sources/CSFBAudioEngine/Decoders/SFBDSFDecoder.m
+++ b/Sources/CSFBAudioEngine/Decoders/SFBDSFDecoder.m
@@ -39 +39,2 @@ static BOOL readChunkID(SFBInputSource *inputSource, uint32_t *chunkID) {
-static void matrixTranspose(const unsigned char *restrict A, unsigned char *restrict B, NSInteger rows, NSInteger columns) {
+static void matrixTranspose(const unsigned char *restrict A, unsigned char *restrict B, NSInteger rows,
+ NSInteger columns) {
Have any feedback or feature suggestions? Share it here.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DSF decoder’s channel deinterleaving step to use a tiled (blocked) matrix transpose implementation when interleaving DSF blocks into clustered frames, aiming to improve cache locality/performance during decoding.
Changes:
- Replaces the naive DSF block transpose with a tiled transpose (
MATRIX_TRANPOSE_BLOCK_SIZE). - Renames internal helper functions used for chunk ID reading and matrix transpose.
- Updates the DSF block read path to call the new transpose implementation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v22.1.6
Click here for the full clang-format patch
diff --git a/Sources/CSFBAudioEngine/Decoders/SFBDSFDecoder.m b/Sources/CSFBAudioEngine/Decoders/SFBDSFDecoder.m
index cdd9e5b..8459255 100644
--- a/Sources/CSFBAudioEngine/Decoders/SFBDSFDecoder.m
+++ b/Sources/CSFBAudioEngine/Decoders/SFBDSFDecoder.m
@@ -39,2 +39 @@ static BOOL readChunkID(SFBInputSource *inputSource, uint32_t *chunkID) {
-static void matrixTranspose(const unsigned char *restrict A, unsigned char *restrict B, size_t rows,
- size_t columns) {
+static void matrixTranspose(const unsigned char *restrict A, unsigned char *restrict B, size_t rows, size_t columns) {
Have any feedback or feature suggestions? Share it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.