Avoid deinterleaving when possible#913
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Musepack and MPEG decoders to prefer interleaved float PCM output so they can copy decoded samples directly (via memcpy) instead of performing per-channel deinterleaving loops.
Changes:
- Switch
SFBMusepackDecoderandSFBMPEGDecoderprocessing formats to interleavedAVAudioPCMFormatFloat32. - Replace manual deinterleaving loops with direct bulk copies into the internal
AVAudioPCMBufferstorage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/CSFBAudioEngine/Decoders/SFBMusepackDecoder.m | Outputs interleaved float PCM and copies decoded interleaved frames directly into _buffer. |
| Sources/CSFBAudioEngine/Decoders/SFBMPEGDecoder.m | Outputs interleaved float PCM and copies mpg123’s decoded interleaved frames directly into _buffer (but frame length calculation needs correction). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.