Skip to content

Fix WavPack sample shift #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbooth merged 1 commit into from
May 25, 2026
Merged

Fix WavPack sample shift #916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Sources/CSFBAudioEngine/Decoders/SFBWavPackDecoder.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,11 +470,11 @@ - (BOOL)decodeIntoBuffer:(AVAudioPCMBuffer *)buffer frameLength:(AVAudioFrameCou
buffer.audioBufferList->mBuffers[0].mDataByteSize,
_buffer, samplesRead * WavpackGetNumChannels(_wpc) * sizeof(float));
} else if (mode & MODE_LOSSLESS) {
// For lossless files WavPack produces 32-bit signed integers with the samples low-aligned
int bitsPerSample = WavpackGetBitsPerSample(_wpc);
if (bitsPerSample != 32) {
// For lossless files WavPack produces 32-bit signed integers with the samples low-aligned in each
// four byte buffer entry but high-aligned within the number of bytes used for the original data
if (WavpackGetBitsPerSample(_wpc) != 32) {
// Shift the samples to high alignment
int shift = 32 - bitsPerSample;
int shift = 32 - (8 * WavpackGetBytesPerSample(_wpc));

uint32_t count = WavpackGetNumChannels(_wpc) * samplesRead;
uint32_t *dst = (uint32_t *)((unsigned char *)buffer.audioBufferList->mBuffers[0].mData +
Expand Down