Fix scale factor for hybrid WavPack audio#917
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the float normalization applied when decoding lossy WavPack streams, ensuring the integer-to-float conversion uses the correct full-scale range based on the container byte width.
Changes:
- Adjusts the lossy-path normalization scale factor to use
WavpackGetBytesPerSample()(byte container width) instead ofWavpackGetBitsPerSample()(nominal bit depth). - Minor line reordering in the lossy conversion block (no functional impact beyond the scale change).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sbooth
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For hybrid files not decoding as lossless