Skip to content

Expose FloorData and TrimsData types in library init.py #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sca075 wants to merge 7 commits into from
Closed

Expose FloorData and TrimsData types in library init.py #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2b5bd0e
adding const.py and update types.py to separate const and types
sca075 Oct 23, 2025
c6ab4ee
last files for 12 isort / ruff and lint
sca075 Nov 4, 2025
e6b006c
remove duplicate import of const
sca075 Dec 19, 2025
a5ca571
const was not properly imported
sca075 Dec 20, 2025
9a370f2
Expose FloorData and TrimsData types in library __init__.py
sca075 Dec 20, 2025
4214ed2
update version in pyproject.toml
sca075 Dec 20, 2025
b3c3082
add TrimData and FloorData to the __init__.py in order to expose them
sca075 Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
{
"branchPrefix": "dev/",
"dryRun": "full",
"username": "renovate-release",
"gitAuthor": "Renovate Bot <bot@renovateapp.com>",
"onboarding": false,
"platform": "github",
"includeForks": true,
"repositories": [
"renovatebot/github-action",
"renovate-tests/cocoapods1",
"renovate-tests/gomod1"
],
"packageRules": [
{
"description": "lockFileMaintenance",
"matchUpdateTypes": [
"pin",
"digest",
"patch",
"minor",
"major",
"lockFileMaintenance"
],
"dependencyDashboardApproval": false,
"stabilityDays": 0
}
]
}
Comment on lines +1 to +29
Copy link

@coderabbitai coderabbitai bot Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Renovate configuration appears to be a template, not customized for this repository.

This configuration has several issues that suggest it's a generic template rather than properly configured:

  1. Location: Renovate configs are typically placed at the repository root as renovate.json or in .github/renovate.json, not in .github/workflows/.

  2. Repository list (lines 9-13): Contains generic Renovate test repositories (renovatebot/github-action, renovate-tests/cocoapods1, renovate-tests/gomod1) instead of this repository's identifier.

  3. Dry-run mode (line 3): "dryRun": "full" means Renovate will only simulate updates without creating actual PRs. This is typically used for testing, not production.

Either remove this file if Renovate isn't needed, or properly configure it with:

  • Correct repository identifier
  • Appropriate dry-run setting (usually false or omit for production use)
  • Correct file location
🤖 Prompt for AI Agents 
.github/workflows/renovate.json lines 1-29: this Renovate config looks like a
generic template placed in the wrong location, lists unrelated test
repositories, and is set to full dry-run; either delete it if you don't intend
to run Renovate, or move it to the repo root (renovate.json) or
.github/renovate.json and update the contents: remove or replace the
"repositories" list with the current repository identifier, set "dryRun" to
false or remove the key for production operation, and adjust any other fields
(e.g., branchPrefix, includeForks, packageRules) to repository-specific values
before committing.

6 changes: 5 additions & 1 deletion SCR/valetudo_map_parser/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""Valetudo map parser.
Version: 0.1.13"""
Version: 0.1.14"""

from pathlib import Path

Expand All @@ -12,6 +12,7 @@
from .config.status_text.translations import translations as STATUS_TEXT_TRANSLATIONS
from .config.types import (
CameraModes,
FloorData,
ImageSize,
JsonType,
NumpyArray,
Expand All @@ -20,6 +21,7 @@
RoomStore,
SnapshotStore,
TrimCropData,
TrimsData,
UserLanguageStore,
)
from .config.utils import ResizeParams, async_resize_image
Expand Down Expand Up @@ -162,6 +164,7 @@ def get_default_font_path() -> str:
"StatusText",
# Types
"CameraModes",
"FloorData",
"ImageSize",
"JsonType",
"NumpyArray",
Expand All @@ -170,6 +173,7 @@ def get_default_font_path() -> str:
"RoomStore",
"SnapshotStore",
"TrimCropData",
"TrimsData",
"UserLanguageStore",
# Utilities
"ResizeParams",
Expand Down
Loading