-
Notifications
You must be signed in to change notification settings - Fork 0
Expose FloorData and TrimsData types in library init.py #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@79f3d049-9006-400d-9954-2e5dcd250fa9.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: SCA075 <82227818+sca075@users.noreply.github.com>
…it bump version in pyproject.toml added to __init__.py Trims and Floor Data Signed-off-by: SCA075 <82227818+sca075@users.noreply.github.com>
📝 WalkthroughWalkthroughBumps package version to 0.1.14, exposes Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
SCR/valetudo_map_parser/__init__.py(3 hunks)SCR/valetudo_map_parser/config/shared.py(0 hunks)pyproject.toml(1 hunks)
💤 Files with no reviewable changes (1)
- SCR/valetudo_map_parser/config/shared.py
🧰 Additional context used
🧬 Code graph analysis (1)
SCR/valetudo_map_parser/__init__.py (1)
SCR/valetudo_map_parser/config/types.py (2)
FloorData(347-363)TrimsData(289-343)
🔇 Additional comments (2)
pyproject.toml (1)
3-3: Version bump looks good.The version increment to 0.1.14 is consistent with the module version in
__init__.py.SCR/valetudo_map_parser/__init__.py (1)
2-2: Version bump is consistent.The module version correctly matches the version in
pyproject.toml.
Signed-off-by: SCA075 <82227818+sca075@users.noreply.github.com>
Signed-off-by: SCA075 <82227818+sca075@users.noreply.github.com>
Signed-off-by: SCA075 <82227818+sca075@users.noreply.github.com>
…ses old key trims_data Signed-off-by: SCA075 <82227818+sca075@users.noreply.github.com>
Expose FloorData and TrimsData types in library init.py
Summary by CodeRabbit
New Features
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.