Skip to content

Work around sbt#8376 and re-enable shapeless-3 community build #24709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gedochao merged 1 commit into from
Dec 9, 2025
Merged

Work around sbt#8376 and re-enable shapeless-3 community build #24709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion community-build/test/scala/dotty/communitybuild/CommunityBuildTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class CommunityBuildTestC:
@Test def scalaz = projects.scalaz.run()
@Test def scas = projects.scas.run()
@Test def sconfig = projects.sconfig.run()
//@Test def shapeless3 = projects.shapeless3.run()
@Test def shapeless3 = projects.shapeless3.run()
@Test def sourcecode = projects.sourcecode.run()
@Test def specs2 = projects.specs2.run()

Expand Down
2 changes: 1 addition & 1 deletion project/Build.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2968,7 +2968,7 @@ object Build {
publishConfiguration ~= (_.withOverwrite(true)),
publishLocalConfiguration ~= (_.withOverwrite(true)),
projectID ~= {id =>
val line = "scala.versionLine" -> versionLine
val line = "info.scala.versionLine" -> versionLine
Copy link
Member

@hamzaremmal hamzaremmal Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we can do this.

Copy link
Contributor

@WojciechMazur WojciechMazur Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen any usages of that so far in any OSS tooling. It would definitely would be something to announce in release notes.

Copy link
Contributor

@tgodzik tgodzik Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When was it added actually? I had no idea there was anything like that available 😅

Also how will it work for 3.9? Would we set it to next or LTS? Doesn't seem altogether that useful

Copy link
Contributor Author

@Gedochao Gedochao Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at a glance, we should be ok to do this.
if there's some obscure usage somewhere, we should catch it during RC.

Copy link
Contributor Author

@Gedochao Gedochao Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We commented almost simultanously 😅

When was it added actually? I had no idea there was anything like that available 😅

git blame says 26.03.2024

Also how will it work for 3.9? Would we set it to next or LTS? Doesn't seem altogether that useful

This is a good question... I'd say it would be LTS for 3.9 line. We shouldn't consider 3.9.0 LTS even for the brief moment when it's the newest version (content-wise, it wouldn't be very different from another patch in 3.8). 3.10.0 would follow soon after.
I guess we'll discuss it on a future Scala Core.

Copy link
Contributor Author

@Gedochao Gedochao Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgodzik it seems we've had it since Scala 3.4.2, but it wasn't widely known, since we seemingly didn't mention it in the release notes 😅

Copy link

@mzuehlke mzuehlke Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had planed to used it in Scala Steward.... but that didn't happen, yet. 😄
scala-steward-org/scala-steward#3328

id.withExtraAttributes(id.extraAttributes + line)
},
Test / publishArtifact := false,
Expand Down
Loading