Skip to content

Fix more whirlpool typos (#47)#47

Open
dfandrich wants to merge 1 commit intoscanoss:mainfrom
dfandrich:whirpool
Open

Fix more whirlpool typos (#47)#47
dfandrich wants to merge 1 commit intoscanoss:mainfrom
dfandrich:whirpool

Conversation

@dfandrich
Copy link

@dfandrich dfandrich commented Feb 4, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the spelling of the Whirlpool hash algorithm ID from "whirpool" to "whirlpool" in documentation and algorithm definitions.

@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

The pull request corrects a typographical error in the Whirlpool hash function definition. The algorithm ID field is updated from the misspelled "whirpool" to the correct spelling "whirlpool" across two files: the README documentation table and the YAML configuration file.

Changes

Cohort / File(s) Summary
Documentation Update
definitions_crypto_algorithms/README.md
Corrected algorithm ID typo in Hash Function table from "whirpool" to "whirlpool".
Configuration File Update
definitions_crypto_algorithms/algorithms/Hash Functions/whirlpool.yaml
Corrected the algorithmId field value from "whirpool" to "whirlpool".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • matiasdaloia

Poem

🐰 A whisker-twitch of joy, I say,
For typos fixed without delay,
"Whirpool" → "Whirlpool" spins so right,
The hash algorithms dance in light! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: fixing typographical errors in 'whirlpool' spelled as 'whirpool' across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@definitions_crypto_algorithms/algorithms/Hash` Functions/whirpool.yaml:
- Around line 1-5: The file name contains a typo: rename the YAML file from
"whirpool.yaml" to "whirlpool.yaml" so it matches the algorithmId "whirlpool"
and avoids tooling/lookup issues; update any references to this file if present
(e.g., imports or index entries) to use "whirlpool.yaml" and confirm the
algorithmId and contents remain unchanged.

Comment on lines 1 to 5
# SPDX-License-Identifier: CC0-1.0
algorithm: Whirlpool Hash Function
algorithmId: whirpool
algorithmId: whirlpool
category: Hash Functions
strength: "128"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Search for any remaining "whirpool" references (paths, ids, docs)
rg -n "whirpool"

# Check for "whirlpool" references to ensure consistency
rg -n "whirlpool"

Repository: scanoss/crypto_algorithms_open_dataset

Length of output: 2225


Rename file to fix typo: whirpool.yamlwhirlpool.yaml.

The filename whirpool.yaml in the algorithms directory is a misspelling of "Whirlpool". The algorithmId is correctly set to whirlpool, but the filename should match. Rename the file to whirlpool.yaml to maintain consistency with the algorithmId and prevent tooling lookup issues.

🤖 Prompt for AI Agents
In `@definitions_crypto_algorithms/algorithms/Hash` Functions/whirpool.yaml around
lines 1 - 5, The file name contains a typo: rename the YAML file from
"whirpool.yaml" to "whirlpool.yaml" so it matches the algorithmId "whirlpool"
and avoids tooling/lookup issues; update any references to this file if present
(e.g., imports or index entries) to use "whirlpool.yaml" and confirm the
algorithmId and contents remain unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant