[jaspr_content] Avoid file descriptor exhaustion during an eager load#770
Merged
schultek merged 4 commits intoschultek:mainfrom Mar 12, 2026
Merged
Conversation
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Package Version ReportThe following packages have been updated: |
parlough
force-pushed
the
fix/file-descriptor-exhaustion
branch
from
de71f0e to
7000a97
Compare
parlough
force-pushed
the
fix/file-descriptor-exhaustion
branch
from
7000a97 to
a958360
Compare
Contributor
Author
|
@schultek Any thoughts on this solution? At first I considered adjusting the load logic itself, but this seemed more flexible as weren't not in control of the |
schultek
reviewed
Mar 11, 2026
Owner
schultek
left a comment
schultek
left a comment
There was a problem hiding this comment.
Direction looks good, just think we can tweak the parallelization a bit.
schultek
approved these changes
Mar 12, 2026
Owner
schultek
left a comment
schultek
left a comment
There was a problem hiding this comment.
Thanks for making the changes, LGTM now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some contributors were hitting this on macOS when building docs.flutter.dev, since the load call ran until it awaited I/O calls. Then by the time we
awaited the results of the loads, potentially many file descriptors were open.To avoid this case, when eagerly loading page sources:
loadon them right away, just track the sources themselves.