Skip to content

fix: remove extra space when author is empty#707

Merged
agriyakhetarpal merged 1 commit intoscientific-python:mainfrom
henryiii:patch-1
Apr 6, 2026
Merged

fix: remove extra space when author is empty#707
agriyakhetarpal merged 1 commit intoscientific-python:mainfrom
henryiii:patch-1

Conversation

@henryiii
Copy link
Copy Markdown
Contributor

@henryiii henryiii commented Apr 4, 2026

This removes the extra space when author is empty. (like on https://learn.scientific-python.org, where it says © 2026 . All rights reserved..

The with only executes if it's non-empty, and . is the object in the with.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 4, 2026

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 06416c2
🔍 Latest deploy log https://app.netlify.com/projects/scientific-python-hugo-theme/deploys/69d09440adb79a0008000c1a
😎 Deploy Preview https://deploy-preview-707--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92
Accessibility: 97
Best Practices: 100
SEO: 91
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@henryiii
Copy link
Copy Markdown
Contributor Author

henryiii commented Apr 4, 2026

Nice to see netlify! :)

@agriyakhetarpal agriyakhetarpal self-requested a review April 4, 2026 20:16
@agriyakhetarpal agriyakhetarpal added the type: Bug fix Something isn't working label Apr 6, 2026
Copy link
Copy Markdown
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This always bothered me, but I never cared enough to fix it. Thank you! While we're at it, I think we should add authors to the config for all websites, though. Would you like to start doing so, @henryiii? :)

Also, should we be stricter and not allow websites with an empty author?

@agriyakhetarpal agriyakhetarpal added this to the 0.23 milestone Apr 6, 2026
@henryiii
Copy link
Copy Markdown
Contributor Author

henryiii commented Apr 6, 2026

Does it make sense to add an author to the main website? Individual pages makes sense, but just a general website with a few links doesn't seem to.

@agriyakhetarpal
Copy link
Copy Markdown
Member

I think the author in the config is per-website, yes. The problem is that the main website is fragmented and built by collating multiple repo sources, so changes have to be reflected to multiple repos (I'm looking at the SPECs :D).

@agriyakhetarpal agriyakhetarpal merged commit aee9eb7 into scientific-python:main Apr 6, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: Bug fix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants