Skip to content

Conversation

@mdealencar
Copy link
Contributor

conda on Windows uses CONDA_PREFIX/Library/{include,lib} instead of the CONDA_PREFIX/{include,lib} previously used in setup.py. This PR checks the system platform and uses the correct paths. Additionally, it makes the variable includedirs always a list, which also solves a failure in building.

@Joao-Dionisio
Copy link
Member

Hey @mdealencar thank you! I'm not a big infrastructure guy, but is this essentially doing the same as #1106 but for conda?

@mdealencar
Copy link
Contributor Author

mdealencar commented Dec 4, 2025

It seems like #1106 left out one assignment of includedirs as a str, which caused the error I observed (and is fixed in this PR). But this PR fixes also a mistake in the actual lib and include paths within the conda environment, which is different on Windows than on POSIX systems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes conda environment path configuration for Windows builds by using the correct Library/include and Library/lib subdirectories within CONDA_PREFIX, as conda on Windows uses a different directory structure than other platforms. The change also ensures includedirs is consistently defined as a list, preventing build failures.

  • Platform-specific conda path handling for Windows vs non-Windows systems
  • Consistent list format for includedirs variable across all platforms

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Joao-Dionisio and others added 4 commits December 4, 2025 18:14
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Joao-Dionisio Joao-Dionisio merged commit c2d8cfd into scipopt:master Dec 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants