♻️ Replace assertions with explicit exceptions #505
Merged
+16
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiWeiss
force-pushed
the
fix/replace-assertions-with-exceptions
branch
2 times, most recently
from
e075741 to
cd0ff29
Compare
MiWeiss
changed the title
MiWeiss
force-pushed
the
fix/replace-assertions-with-exceptions
branch
from
cd0ff29 to
2eeb8a0
Compare
MiWeiss
force-pushed
the
fix/replace-assertions-with-exceptions
branch
from
2eeb8a0 to
84215e7
Compare
Collaborator
Author
|
change by claude |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace assert statements with explicit if + raise ValueError in _cast_to_duplicate() to ensure checks run even with Python -O flag.