Running upstream opengraph PHP library maintenance#30
Open
AramZS wants to merge 15 commits intoscottmac:masterfrom
Open
Running upstream opengraph PHP library maintenance#30AramZS wants to merge 15 commits intoscottmac:masterfrom
AramZS wants to merge 15 commits intoscottmac:masterfrom
Conversation
Bringing my base up to date
The property `_values` was misnamed as `values` causing the function to always consider image retrieval a failure, often not offering an alternative. Discovered this problem while working on PressForward. This simple fix should resolve a ton of problems, most notably scottmac#29.
AramZS
added a commit
to PressForward/pressforward
that referenced
this pull request
Jan 8, 2015
Note pull request at scottmac/opengraph#30 - the misnaming of this variable was causing OG to consistently fail to find an image.
douglaslinsmeyer
pushed a commit
to douglaslinsmeyer/pressforward
that referenced
this pull request
Feb 19, 2015
Note pull request at scottmac/opengraph#30 - the misnaming of this variable was causing OG to consistently fail to find an image.
The $_SERVER globals may not be present (e.g. when using cronjobs, etc.). Using "facebookexternalhit" scraped pages will behave the same as to the original facebook scraper
OpenGraph now support UTF-8 Encoding.
This will require more testing, but I think it is a great idea if it works.
AramZS
changed the title
Contributor
Author
|
Changing name from: "Fix constant OG:Image failure due to mistyped variable. " to "Running upstream opengraph PHP library maintenance." This branch now reflects an attempt to keep the project up to date with the latest useful pull requests to the now seemingly abandoned project base. |
Pulled from scottmac#25 with some corrections. Twitter advises the name attribute to set tags.
…nged to array. This way it supports multiple entries of the same key - namely image.
This should allow devs using the library to retrieve HTML pages through other methods, if they wish, and parse them using the OpenGraph library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property
_valueswas misnamed asvaluescausing the function to always consider image retrieval a failure, often not offering an alternative. Discovered this problem while working on PressForward/pressforward. This simple fix should resolve a ton of problems, most notably #29.