Added check for existing key, if key already exists, the entry is cha…#37
Open
GregersBoye wants to merge 1 commit intoscottmac:masterfrom
GregersBoye:multi-key
Open
Added check for existing key, if key already exists, the entry is cha…#37GregersBoye wants to merge 1 commit intoscottmac:masterfrom GregersBoye:multi-key
GregersBoye wants to merge 1 commit intoscottmac:masterfrom
GregersBoye:multi-key
Conversation
…nged to array. This way it supports multiple entries of the same key - namely image.
AramZS
referenced
this pull request
in AramZS/opengraph
Jul 12, 2016
Contributor
|
Excellent work @GregersBoye - I've made some slight modifications to assure that users accessing the system the old way will retain access. By switching it to an array it would have broken any current users systems who were expecting the old method of response. Instead I've set it up to add the additional values into an array under a different key. You can see my alterations above. Since the current maintainer seems to have checked out, I'm maintaining this branch forward of this repo at https://github.com/AramZS/opengraph Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nged to array. This way it supports multiple entries of the same key - namely image.