make ship and weapon class display names SCP_string#7186
Merged
Goober5000 merged 1 commit intoscp-fs2open:masterfrom Feb 15, 2026
Merged
make ship and weapon class display names SCP_string#7186Goober5000 merged 1 commit intoscp-fs2open:masterfrom
Goober5000 merged 1 commit intoscp-fs2open:masterfrom
Conversation
Goober5000
added
enhancement
All other display names are `SCP_string`, so make these `SCP_string` as well to be consistent and to allow arbitrary-length display names. Also fix a few infelicities with German translation and the script API.
Goober5000
force-pushed
the
ship_class_display_name
branch
from
d7bb260 to
b4d9c3e
Compare
wookieejedi
approved these changes
Feb 11, 2026
Member
wookieejedi
left a comment
wookieejedi
left a comment
There was a problem hiding this comment.
Straightforward and works in my tests, too
Goober5000
removed
the
Waiting for Stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All other display names are
SCP_string, so make theseSCP_stringas well to be consistent and to allow arbitrary-length display names.Also fix a few infelicities with German translation and the script API.