-
Notifications
You must be signed in to change notification settings - Fork 180
TTS Speech rework #7357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shivansps
wants to merge
29
commits into
scp-fs2open:master
Choose a base branch
from
Shivansps:speech-rework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TTS Speech rework #7357
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
9ad34dc
add imgui speech options
Shivansps 839d6b6
adapt existing windows sapi speech implementation
Shivansps 618cf58
adapt existing mac speech integration
Shivansps 5a94f87
add speech linux stubs
Shivansps 1efe01b
add speech support in linux
Shivansps ecacd4f
Add array checks
Shivansps ae8e56b
Use dlopen for speech-dispatcher
Shivansps 191061d
corrrect lib name
Shivansps fc5a017
missing includes and static cast
Shivansps 4d71c38
do not change mac file type
Shivansps 0c3534c
fix clang tidy warnings 1
Shivansps be08a77
set tts rate
Shivansps 5e564ad
set localization ids
Shivansps 550ea1e
Merge branch 'master' into speech-rework
Shivansps 205eaef
fix clang tidy warnings 2
Shivansps 5b9d842
Merge branch 'speech-rework' of https://github.com/Shivansps/fs2open.…
Shivansps 5d47980
correct symbol name
Shivansps 0c27de6
Remove voice cache and fix win enumerate_voices overriding voice sele…
Shivansps 127e55a
fix mac rate
Shivansps 6338623
requested changes
Shivansps 191400f
re-add voice cache for linux
Shivansps 8470aa9
Open connection for linux get flags
Shivansps 4c41528
fix missing }
Shivansps 02da89d
change voice option combobox to std::pair
Shivansps e90860f
delete duplicated voice id sanitizer on windows set voice
Shivansps afb7846
Use pairs for speech_enumerate_voices() and adapt linux speech
Shivansps 9fa8840
use reference
Shivansps bf1512f
actually free vector memory
Shivansps dc17cc6
Clear voice cache when ingame options closes
Shivansps File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use quotes instead of angle brackets.
An alternative to using the include here is to just add
extern void fsspeech_options_cleanup();immediately before the call to that function below. That may actually be preferred so that it's easier to remove that code in the future, assuming that the options code eventually gets modified to handle this stuff itself.But either change works.