-
Notifications
You must be signed in to change notification settings - Fork 3
Add profile readme #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+148
−69
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| root = true | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| end_of_line = lf | ||
| indent_size = 2 | ||
| indent_style = space | ||
| insert_final_newline = true | ||
| max_line_length = 118 | ||
| rulers = 80, 118 | ||
| trim_trailing_whitespace = true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,41 @@ | ||
| ## Contributing | ||
| The development of Scratch is an ongoing process, and we love to have people in the Scratch, ScratchJr, and open source communities help us along the way. | ||
| # Contributing | ||
|
|
||
| ### Ways to Help | ||
| The development of Scratch is an ongoing process, and we love to have people in the Scratch, ScratchJr, and open | ||
| source communities help us along the way. | ||
|
|
||
| ## Ways to Help | ||
|
|
||
| * **Documenting bugs** | ||
| * If you've identified a bug in Scratch or ScratchJr, you should first check to see if it's been filed as an issue. If it has not been filed, please file an issue! Make sure you follow the issue template. | ||
| * It's important that we can consistently reproduce issues. When writing an issue, be sure to follow our [reproduction step guidelines](https://github.com/LLK/scratch-gui/wiki/Writing-good-repro-steps). | ||
| * Some issues are marked "Needs Repro". Adding a comment with good reproduction steps to those issues is a great way to help. | ||
| * If you don't have an issue in mind already, you can look through the [Bugs & Glitches forum.](https://scratch.mit.edu/discuss/3/) Look for users reporting problems, reproduce the problem yourself, and file new issues following our guidelines. | ||
| * If you've identified a bug in Scratch or ScratchJr, you should first check to see if it's been filed as an issue. | ||
| If it has not been filed, please file an issue! Make sure you follow the issue template. | ||
| * It's important that we can consistently reproduce issues. When writing an issue, be sure to follow our | ||
| [reproduction step guidelines](https://github.com/LLK/scratch-gui/wiki/Writing-good-repro-steps). | ||
| * Some issues are marked "Needs Repro". Adding a comment with good reproduction steps to those issues is a great | ||
| way to help. | ||
| * If you don't have an issue in mind already, you can look through the [Bugs & Glitches forum.]( | ||
| https://scratch.mit.edu/discuss/3/) Look for users reporting problems, reproduce the problem yourself, and file | ||
| new issues following our guidelines. | ||
|
|
||
| * **Fixing bugs** | ||
| * **We will only accept Pull Requests for bugs that have an issue filed with a priority label** | ||
| * If you're interested in fixing a bug that does not have an issue already, please file the issue first and wait for it to have a priority added to it. | ||
| * You can request to fix a bug in a comment on the issue if you mention the repo coordinator for this repository, using the @ symbol with their Github username. Check the list of [Repository Coordinators](./CONTRIBUTING.md#repository-coordinators) to find out who to @-mention. | ||
| * The "help wanted" label indicates issues that the Scratch Team thinks would be appropriate for an external contributor to work on. You should still wait for an issue to be prioritized before working on it or submitting a PR. | ||
| * **We will only accept Pull Requests for bugs that have an issue filed with a priority label** | ||
| * If you're interested in fixing a bug that does not have an issue already, please file the issue first and wait | ||
| for it to have a priority added to it. | ||
| * You can request to fix a bug in a comment on the issue if you mention the repo coordinator for this repository, | ||
| using the @ symbol with their Github username. Check the list of [Repository Coordinators]( | ||
| ./CONTRIBUTING.md#repository-coordinators) to find out who to @-mention. | ||
| * The "help wanted" label indicates issues that the Scratch Team thinks would be appropriate for an external | ||
| contributor to work on. You should still wait for an issue to be prioritized before working on it or submitting | ||
| a PR. | ||
| * We are not looking for Pull Requests ("PR") for every issue and may deny a PR if it doesn't fit our criteria. | ||
| * We are far more likely to accept a PR if it is for an issue marked with the "Help Wanted" label. | ||
| * We will not accept PRs for issues marked with "Needs Discussion" or "Needs Design." | ||
| * Wait until an issue has been assigned a priority before working on it. Also leave a comment if you start working on a prioritized issue, so other people don't start working on it also. | ||
| * Wait until an issue has been assigned a priority before working on it. Also leave a comment if you start working | ||
| on a prioritized issue, so other people don't start working on it also. | ||
|
|
||
| ## Repository Coordinators | ||
|
|
||
| #### Repository Coordinators | ||
| Public repositories where we encourage contributions have a repository coordinator. Here are the current assignments: | ||
|
|
||
| * scratch-audio @ericrosenbaum | ||
| * scratch-blocks @ericrosenbaum | ||
| * scratch-desktop @cwillisf | ||
|
|
@@ -35,54 +50,77 @@ Public repositories where we encourage contributions have a repository coordinat | |
| * scratchjr-website @chrisgarrity | ||
|
|
||
| Repositories that do not accept external PRs: | ||
|
|
||
| * scratch-l10n | ||
| * scratch-paint | ||
| * scratch-parser | ||
| * scratch-render-fonts | ||
| * scratch-resources | ||
| * scratch-sb1converter | ||
|
|
||
| ### Learning Git and Github | ||
| ## Learning Git and Github | ||
|
|
||
| If you want to work on fixing issues, you should be familiar with Git and Github. | ||
|
|
||
| * [Learn Git branching](https://learngitbranching.js.org/) includes an introduction to basic git commands and useful branching features. | ||
| * Here's a general introduction to [contributing to an open source project](https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github). | ||
| * [Learn Git branching](https://learngitbranching.js.org/) includes an introduction to basic git commands and useful | ||
| branching features. | ||
| * Here's a general introduction to [contributing to an open source project]( | ||
| https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github). | ||
|
|
||
| **Important:** we follow the [Github Flow process](https://guides.github.com/introduction/flow/) as our development | ||
| process. | ||
|
|
||
| **Important:** we follow the [Github Flow process](https://guides.github.com/introduction/flow/) as our development process. | ||
| ## How to Fix Bugs | ||
|
|
||
| ### How to Fix Bugs | ||
| 1. Identify which Github issue you are working on. Leave a comment on the issue to let us (and other contributors) know you're working on it. | ||
| 2. Make sure you have a fork of this repo (see [Github's forking a repo](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) for details) | ||
| 1. Identify which Github issue you are working on. Leave a comment on the issue to let us (and other contributors) | ||
| know you're working on it. | ||
| 2. Make sure you have a fork of this repo (see [Github's forking a repo]( | ||
|
Comment on lines
24
to
77
|
||
| https://help.github.com/en/github/getting-started-with-github/fork-a-repo) for details) | ||
| 3. Switch to the `develop` branch, and pull down the latest changes from upstream | ||
| 4. Run the code, and reproduce the problem | ||
| 5. Create your branch from the `develop` branch | ||
| 6. Make code changes to fix the problem | ||
| 7. Test your changes and make sure existing tests pass. In most scratch repositories running `npm test` will run the tests. We strongly encourage you to write tests for any changes. | ||
| 7. Test your changes and make sure existing tests pass. In most scratch repositories running `npm test` will run the | ||
| tests. We strongly encourage you to write tests for any changes. | ||
| 8. Commit your changes | ||
| 9. Push your branch to your fork | ||
| 10. Create your pull request | ||
| 1. Make sure to follow the template in the PR description | ||
| 1. Remember to check the “[Allow edits from maintainers](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork)” box | ||
| 2. Remember to check the "[Allow edits from maintainers]( | ||
| https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork | ||
| )" box | ||
|
|
||
| When submitting pull requests, keep in mind: | ||
|
|
||
| When submitting pull requests keep in mind: | ||
| * please be patient -- it can take a while to find time to review them | ||
| * try to change the least amount of code necessary to fix the bug | ||
| * the code can't be radically changed without significant coordination with the Scratch Team, so these types of changes should be avoided | ||
| * if you find yourself changing a substantial amount of code or considering radical changes, please ask for clarification -- we may have envisioned a different approach, or underestimated the amount of effort | ||
| * the code can't be radically changed without significant coordination with the Scratch Team, so these types of | ||
| changes should be avoided | ||
| * if you find yourself changing a substantial amount of code or considering radical changes, please ask for | ||
| clarification -- we may have envisioned a different approach, or underestimated the amount of effort | ||
|
|
||
| ## Suggestions | ||
|
|
||
| ### Suggestions | ||
|  | ||
|
|
||
| Please note: **_we are unlikely to accept PRs with new features that haven't been thought through and discussed as a group_**. | ||
| Please note: **_we are unlikely to accept PRs with new features that haven't been thought through and discussed as a | ||
| group_**. | ||
|
|
||
| Why? Because we have a strong belief in the value of keeping things simple for new users. It's been said that the Scratch Team spends about one hour of design discussion for every pixel in Scratch. To learn more about our design philosophy, see [the Scratch Developers page](https://scratch.mit.edu/developers), or [this paper](http://web.media.mit.edu/~mres/papers/Scratch-CACM-final.pdf). | ||
| Why? Because we have a strong belief in the value of keeping things simple for new users. It's been said that the | ||
| Scratch Team spends about one hour of design discussion for every pixel in Scratch. To learn more about our design | ||
| philosophy, see [the Scratch Developers page](https://scratch.mit.edu/developers), or [this paper]( | ||
| http://web.media.mit.edu/~mres/papers/Scratch-CACM-final.pdf). | ||
|
|
||
| We welcome suggestions! If you want to suggest a feature, please post in our [suggestions forum](https://scratch.mit.edu/discuss/1/). Your suggestion will be helped if you include a mockup design; this can be simple, even hand-drawn. | ||
| We welcome suggestions! If you want to suggest a feature, please post in our [suggestions forum]( | ||
| https://scratch.mit.edu/discuss/1/). Your suggestion will be helped if you include a mockup design; this can be | ||
| simple, even hand-drawn. | ||
|
|
||
| ## Other resources | ||
|
|
||
| ### Other resources | ||
| Beyond this repo, there are also some other resources that you might want to take a look at: | ||
| * [Community Guidelines](https://github.com/LLK/scratch-www/wiki/Community-Guidelines) (we find it important to maintain a constructive and welcoming community, just like on Scratch) | ||
|
|
||
| * [Community Guidelines](https://github.com/LLK/scratch-www/wiki/Community-Guidelines) (we find it important to | ||
| maintain a constructive and welcoming community, just like on Scratch) | ||
| * [Open Source forum](https://scratch.mit.edu/discuss/49/) on Scratch | ||
| * [Suggestions forum](https://scratch.mit.edu/discuss/1/) on Scratch | ||
| * [Bugs & Glitches forum](https://scratch.mit.edu/discuss/3/) on Scratch | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,18 +1,28 @@ | ||||||
| ### Resolves | ||||||
| --- | ||||||
| name: Pull Request | ||||||
| about: Submit a Pull Request to contribute changes | ||||||
| title: '' | ||||||
| labels: '' | ||||||
| assignees: '' | ||||||
|
|
||||||
| _What Github issue does this resolve (please include link)? Please do not submit PRs that are not associated with an issue, or that only partially implement a fix._ | ||||||
| --- | ||||||
| ## Resolves | ||||||
|
|
||||||
| - Resolves # | ||||||
| _What GitHub issue does this resolve (please include link)? Please do not submit PRs that are not associated with an | ||||||
| issue, or that only partially implement a fix._ | ||||||
|
|
||||||
| ### Proposed Changes | ||||||
| - Resolves #0 | ||||||
|
||||||
| - Resolves #0 | |
| - Resolves #ISSUE_NUMBER |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| # .github | ||
|
|
||
| Scratch community health files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Scratch | ||
|
|
||
| [Scratch](https://scratch.mit.edu) is the world's largest creative learning platform inviting young people to think | ||
| critically, work collaboratively, and develop the skills they need to thrive in our changing world. We provide | ||
| accessible tools and experiences for kids everywhere to explore their ideas, express themselves, and connect with | ||
| others through the things they create. Since 2007, millions of kids worldwide have created over 1 billion Scratch | ||
| projects in our safe, creative, and free community. Learn more about the nonprofit [Scratch]( | ||
| https://scratchfoundation.org). | ||
|
|
||
| We believe every child deserves the chance to express themselves creatively—and have fun doing it. More than just a | ||
| tool for learning to code, Scratch helps kids develop the skills they need to thrive: creativity, problem-solving, | ||
| collaboration, and confidence. | ||
|
|
||
| ## Open Source at Scratch | ||
|
|
||
| The Scratch Team is committed to open-source development. Many of our applications and components are public and open | ||
| for contribution. Please keep in mind that we are a small team, so we may not be able to respond in detail to every | ||
| contribution. We appreciate your patience and understanding. | ||
|
|
||
| The [scratch-editor](https://github.com/scratchfoundation/scratch-editor) repository is a monorepo containing the main | ||
| components of the Scratch editor and player, and is a good place to start. | ||
|
|
||
| Ready to contribute? Check out our general [contributing guidelines]( | ||
| https://github.com/scratchfoundation/.github/blob/main/CONTRIBUTING.md) as well as any repository-specific | ||
| documentation. Thank you! | ||
|
|
||
| ## Get Involved | ||
|
|
||
| - **Learn More**: Visit <https://scratchfoundation.org> to learn more about Scratch. | ||
| - **Impact**: Read about our [global impact](https://scratchfoundation.org/impact) and annual reports. | ||
| - **Support**: Consider [donating](https://scratchfoundation.org/donate) or [becoming a | ||
| Member](https://scratchfoundation.org/membership) to support our mission. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The property "rulers" is not part of the official EditorConfig specification. While some editors like VS Code may recognize this property, it will be ignored by most EditorConfig-compliant editors. Consider removing this property or documenting it as editor-specific configuration that should be placed in editor-specific settings files instead.