Skip to content

Comments

[UEPR-494] Text field not automatically focused#443

Open
adzhindzhi wants to merge 1 commit intodevelopfrom
hotfix/text-field-not-automatically-focused
Open

[UEPR-494] Text field not automatically focused#443
adzhindzhi wants to merge 1 commit intodevelopfrom
hotfix/text-field-not-automatically-focused

Conversation

@adzhindzhi
Copy link
Contributor

@adzhindzhi adzhindzhi commented Feb 12, 2026

Resolves

UEPR-494

Proposed Changes

  • Only attempt to blur if the currently focused element is actually the tab, rather than always blurring

Reason for Changes

  • The text field gains focus before our attempt to blur focus from the tabs, which results in users not being able to type right away

@adzhindzhi adzhindzhi requested a review from a team as a code owner February 12, 2026 14:52
Copy link
Contributor

@KManolov3 KManolov3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it might be good to have this on the other tabs as well, but this should be the lowest risk change-set for a hotfix.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

Test report for scratch-gui

  2 files  ±0   62 suites  ±0   9m 1s ⏱️ -40s
398 tests ±0  390 ✅ ±0  8 💤 ±0  0 ❌ ±0 
416 runs  ±0  408 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit a9110b7. ± Comparison against base commit 522f9c1.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with both parts of what @KManolov3 said :)
I'm tempted to suggest moving this to a base class for tabs, but maybe that's my C++ background talking...
This seems good as a specific bug fix, though. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants