Skip to content

Conversation

@bhanu-dev82
Copy link
Collaborator

Contributor checklist


Description

This PR addresses issue #509 by organizing the test files into the correct package structure and cleaning up unused/invalid tests. It also adds new unit tests to improve code coverage.

Changes:

  • Reorganization: Moved AlphanumericComparatorTest and KeyboardTest to their correct packages (be.scri.helpers) to match the source code structure.
  • Cleanup: Removed ComprehensiveCoverageTest.kt as it was a dummy test providing no real value.
  • Renaming: Renamed DatabaseTest to PluralFormsManagerTest to better reflect its purpose and location.
  • New Tests: Added StringUtilsTest to improve unit test coverage for the isWordCapitalized function.

Verification:

  • Verified file structure matches the source code structure.
  • Ran ./gradlew testCoreDebugUnitTest to ensure all unit tests pass (Build Successful).

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Jan 22, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bhanu-dev82

Everything looks good to me. Thanks for the quick work.

@angrezichatterbox angrezichatterbox merged commit 384ce54 into scribe-org:main Jan 22, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Organize the tests in the repository

2 participants