Skip to content

Conversation

@bhanu-dev82
Copy link
Collaborator

Contributor checklist


Description

This PR adds a unit test to KeyboardTest.kt to verify the behavior of the Enter key. It simulates pressing the Enter key via the KeyHandler and asserts that the corresponding KeyEvents (ACTION_DOWN and ACTION_UP) are sent to the InputConnection.

Changes

  • Modified app/src/androidTest/kotlin/be/scri/helpers/KeyboardTest.kt: Added testEnterKeyInsertsNewLine.

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Jan 22, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Thanks so much for all the commits recently, @bhanu-dev82!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: All's looking great here, @bhanu-dev82! Thanks for picking up the issue and getting to the contribution so quickly!

@andrewtavis
Copy link
Member

Merging after tests pass :)

@andrewtavis andrewtavis merged commit 75c9f7e into scribe-org:main Jan 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test for Enter key inserts new line correctly

2 participants