sumcheck skip send p0 #1247
Merged
sumcheck skip send p0 #1247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
commented
Jan 28, 2026
| } | ||
| } | ||
| let final_sum = SepticPoint::from_affine(final_sum_x, final_sum_y); | ||
| assert_eq!(zerocheck_proof.extract_sum(), E::ZERO); |
Collaborator
Author
There was a problem hiding this comment.
this util function extract_sum no longer valid as now uni-variate lack of p0. We can do the zero check in sanity stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1233
refer https://eprint.iacr.org/2024/108.pdf "sec 3.1"
benchmark
send one less interpolation show significant improvement on
prove_tower_relation_gpu. Forprove_main_constraints,pcs_openingthere is no significant different and most likely noiseraw data